Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves issue #50 during the first puppet run if cups is not installed. Some investigation into this issue revealed that
lib/puppet/prividers/printer/cups.rb
gets processed prior to any configuration.When cups is not installed, commands
cupsenable
,cupsdisable
,cupsaccept
, andcupsreject
are never set resulting, in the errorCould not evaluate: undefined method 'cupsenable' for #
as you can see in the below code snippet.Essentially during a puppet run the following happens:
lib/puppet/prividers/printer/cups.rb
By using unqualified binary paths we rely on the system path and therefore don't have worry if the binary is in
/usr/bin
or/usr/sbin
.From the puppet documentation
With this patch, if the user does not have cups installed and does not
include cups
they will get this error messageError: Could not find a suitable provider for printer
, however puppet will complete the run without aborting.