Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiera_hash lookup introduced in d0abd007 fails if not supplied hash #53

Open
mattyindustries opened this issue Jul 20, 2015 · 2 comments

Comments

@mattyindustries
Copy link

I've just upgraded my CUPS module to master to bring in Pull Request #52 to resolve #50 as I was having this problem.

Because of this I have also included commit d0abd00 which introduces hiera support for the variable
cups::printers.

If you don't set a hiera variable of cups::printers now an error is logged

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find data item cups::printers in any Hiera data file and no default supplied at /app/puppet/sapv2_cups/puppet/modules/cups/manifests/init.pp:21 on node toyecq01.tmca.com.au
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

I have my own hiera variable that I use to store the cups printer definitions and I could swap this over to use cups::printers but this is probably not the behaviour you want especially if someone isn't using hiera.

Adding a blank default to the hiera_hash might resolve this issue but haven't tested it yet. I'll hopefully get some time to play around with a couple of options and submit a pull request in the next few days.

@mattyindustries
Copy link
Author

I've just raised Pull Request #54 to cover this issue

@mosen
Copy link
Owner

mosen commented Jul 23, 2015

Thanks a bunch. Will review and merge in a few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants