Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deviation of local filename.string.json from en.json for English translation #644

Open
tilak-puli opened this issue Mar 15, 2023 · 0 comments
Labels
enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet

Comments

@tilak-puli
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Right now, There are two places where English translation texts are added.

  1. In en.json
  2. *.strings.json of file which is using the respective string

Looks like en.json is autogenerated and developer is not supposed to add translations. There is a pre lint script to copy translations from *.strings.json to en.json. As developers are unaware of this setup, Some developers added translations directly to en.json but not *.strings.json. Due to this, each time some changes happens in English translation script is overriding en.json with old/missing translations. If someone commits these changes, this will create a major issue for the app.

Describe the solution you'd like
One of the following solutions can fix the issue.

  1. Update all *.strings.json with latest changes in en.json and add a comment to en.json stating that this file is a auto generated and avoid doing modification. instead change respective *.strings.json
  2. Remove the script which generates en.json and delete all *.strings.json

Please discuss with the team and select one of above option based on team preference.

@tilak-puli tilak-puli added enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet labels Mar 15, 2023
@santhoshsunder santhoshsunder added bug Something isn't working and removed bug Something isn't working labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet
Projects
None yet
Development

No branches or pull requests

2 participants