-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dangerous_limit paramter for WithCPUDump method #37
Comments
Heap Dump has the same scene. |
It's a good idea, and I prefer the latter too, we could configure not any CPU,but also mem and goroutine etc. |
in my previous experiments, if goroutine num is huge, eg. 100k |
how we measure this parameter, I mean it's difficult to have a common goroutine number limit on different machines, unlike CPU or memory can be measured in percent. |
Yes, it's hard to configure a universal value for every type of application load, if some users use this lib in their own app, maybe they can figure out a proper value with consideration on their own type of workload? I'm not sure |
@cch123 ok, I will create a new pr, but before that, I want to discuss does this parameter control only goroutine profile dumping or all types profile dumping? in other words, Line 155 in 04a2f16
or change Line 168 in 04a2f16
|
only setting limit on goroutineCheckAndDump is ok, be careful about the naming~ |
In my opinion, if this goroutine parameter control all types profile dumping, use global |
Hi team,
In my opinion, there is should be a
dangerous_limit
parameter means holmes will not dump profile when current CPU usage reached this limit, cuz CPU pprof usually waste some resource, commonly 5% or less, if holmes executes the CPU pprof causes CPU usage up 5% and result of the service crash, I won't hope that.change to
or add a new withOption func
I prefer the latter.
The text was updated successfully, but these errors were encountered: