Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add integrate test #795

Merged
merged 22 commits into from
Oct 19, 2022
Merged

test: add integrate test #795

merged 22 commits into from
Oct 19, 2022

Conversation

bxiiiiii
Copy link
Contributor

What this PR does:
Add more components and api features in integrate test

Which issue(s) this PR fixes:

Fixes #415

@bxiiiiii bxiiiiii mentioned this pull request Sep 25, 2022
Closed
@seeflood seeflood mentioned this pull request Sep 26, 2022
Closed
zhenjunMa
zhenjunMa previously approved these changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@zhenjunMa zhenjunMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 10, 2022 •
edited
Loading

Codecov Report

Base: 60.55% // Head: 60.55% // No change to project coverage 👍

Coverage data is based on head (ad42ff9) compared to base (10b0313).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #795   +/-   ##
=======================================
  Coverage   60.55%   60.55%           
=======================================
  Files         135      135           
  Lines        8815     8815           
=======================================
  Hits         5338     5338           
  Misses       2823     2823           
  Partials      654      654

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seeflood
add comments
87d14e3 
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
bxiiiiii and others added 4 commits October 18, 2022 18:42
@bxiiiiii
fix znode not exit
49ed1a4
@seeflood
Merge branch 'main' into fix#415
d18efaf
@seeflood
set -e
23c16c5 
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood
panic to test CI
c5ac3ee 
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood
demo panics to test CI
401455b 
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood
Copy link
Member

seeflood commented Oct 19, 2022 •
edited
Loading

@bxiiiiii Hi, you don't have to do it:
image

Let me revert your commits. I'm testing the CI.

  • CI report error when integrate test cases panic
  • CI report error when integrate test cases fail
  • CI report error when demos fail

@seeflood
add wrong assertions to test CI
a461785 
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood
fix error
ad42ff9 
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
seeflood
seeflood approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!
I modified your branch to make sure CI will report error when test cases fail

@seeflood seeflood merged commit 18ceced into mosn:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenxuwan wenxuwan wenxuwan approved these changes

@seeflood seeflood seeflood approved these changes

@zhenjunMa zhenjunMa Awaiting requested review from zhenjunMa

Assignees
No one assigned
Labels
cla:yes size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GLCC] Add more components and api features in integrate test
4 participants
@bxiiiiii @seeflood @wenxuwan @zhenjunMa