Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Integrate test #702

Closed
wants to merge 0 commits into from
Closed

test: Integrate test #702

wants to merge 0 commits into from

Conversation

bxiiiiii
Copy link
Contributor

@bxiiiiii bxiiiiii commented Jul 7, 2022

What this PR does:
Add more components and api features in integrate test
Which issue(s) this PR fixes:

Fixes #415

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Base: 60.56% // Head: 60.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a12ae09) compared to base (767f58f).
Patch has no changes to coverable lines.

❗ Current head a12ae09 differs from pull request most recent head ea07618. Consider uploading reports for the commit ea07618 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         133      133           
  Lines        8340     8323   -17     
=======================================
- Hits         5051     5041   -10     
+ Misses       2712     2705    -7     
  Partials      577      577           
Impacted Files Coverage Δ
components/rpc/invoker/mosn/mosninvoker.go 65.00% <0.00%> (-7.73%) ⬇️
pkg/runtime/config.go 60.00% <0.00%> (ø)
pkg/runtime/options.go 43.33% <0.00%> (ø)
components/rpc/types.go 53.84% <0.00%> (ø)
components/hello/helloworld/helloworld.go 100.00% <0.00%> (ø)
sdk/go-sdk/client/client.go 93.33% <0.00%> (+1.02%) ⬆️
pkg/runtime/runtime.go 60.32% <0.00%> (+1.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bxiiiiii bxiiiiii changed the title [GLCC]Integrate test [tests]Integrate test Jul 14, 2022
@bxiiiiii bxiiiiii changed the title [tests]Integrate test [test]Integrate test Jul 14, 2022
@bxiiiiii bxiiiiii changed the title [test]Integrate test test: Integrate test Jul 14, 2022
sdk/go-sdk/test/runtime/etcd_integrate_test.go Outdated Show resolved Hide resolved
sdk/go-sdk/test/runtime/etcd_integrate_test.go Outdated Show resolved Hide resolved
sdk/go-sdk/test/runtime/zookeeper_integrate_test.go Outdated Show resolved Hide resolved
sdk/go-sdk/test/runtime/etcd_integrate_test.go Outdated Show resolved Hide resolved
@zhenjunMa
Copy link
Contributor

另外关于zkCreateZNode.sh 脚本里的内容本质上是由于Layotto实现有问题导致的,详细信息可用参考 #747
感兴趣也可以fix一下🤝

zhenjunMa
zhenjunMa previously approved these changes Aug 12, 2022
Copy link
Contributor

@zhenjunMa zhenjunMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bxiiiiii
Copy link
Contributor Author

@zhenjunMa @seeflood
I accidentally closed this pr, you can check #795 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GLCC] Add more components and api features in integrate test
3 participants