Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Typo in english, and translation related question #14

Closed
Zorrototo opened this issue Sep 7, 2021 · 4 comments
Closed

Typo in english, and translation related question #14

Zorrototo opened this issue Sep 7, 2021 · 4 comments

Comments

@Zorrototo
Copy link
Contributor

Zorrototo commented Sep 7, 2021

There is a typo in the english language files, it is written 'occured' instead of 'occurred'

Also I was willing to send a french translation file, but I couldn't find a way to test it. I tried to build following the README (and I tried to name the file and the Language line to "fr" and "fr_FR", as well as adding the value to the LINGUAS file too), but when I start the executable it is in english instead of french.

Is there something specific to do?

@moson-mo
Copy link
Owner

moson-mo commented Sep 7, 2021

For applying changes to translations, those would need to be installed in order to see it in the app.
ninja -C build install

You can just copy "de" to "fr", make the changes and make a pull request. I'll have a look at the "occured" thing...

@Zorrototo
Copy link
Contributor Author

Zorrototo commented Sep 16, 2021

I was unable to have it to work. So in the end I can't verify my translation fits the UI, and the different cases by using simply "fr" and/or the various other french variants (which are the same language). I will create a PR for the language file itself, with no verification made to it sorry.

//EDIT: done #15

//EDIT2: if it helps here are the variants for French language, there is no difference, at least for such program (no currency/temperature unit so it should be all the same here):

Belgium: fr_BE
Canada: fr_CA
Switzerland: fr_CH
France: fr_FR
Luxembourg: fr_LU

I made just a "fr" lang file in the hope it will work for all. In the end it may be required to have all variants, I don't know.

@moson-mo
Copy link
Owner

Thanks. Merged it.

If you want to try it out:

mkdir matray-git
cd matray-git
wget "https://raw.githubusercontent.com/moson-mo/matray/master/resources/misc/PKGBUILD"
makepkg -i

What's your language setting, fr_FR ?

I made just a "fr" lang file in the hope it will work for all. In the end it may be required to have all variants, I don't know.

I'd assume it will fall back to "fr", not sure either though :)

@Zorrototo
Copy link
Contributor Author

Installing this way worked for me, the language is directly assigned to the program (it wasn't working when I tried different ways with ninja build install)
Yes my locale is fr_FR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants