Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of ::Log to better indicate where a message is coming from #78

Closed
robacarp opened this issue Jan 18, 2022 · 0 comments · Fixed by #88
Closed

Update use of ::Log to better indicate where a message is coming from #78

robacarp opened this issue Jan 18, 2022 · 0 comments · Fixed by #88

Comments

@robacarp
Copy link
Collaborator

Currently, mosquito logs look like this:

INFO - mosquito: Success: task queued_job<1642475392146:636> finished and took 13.0µs
INFO - mosquito: Running task custom_serializers_job<1642475392145:418> from custom_serializers_job
INFO - mosquito: using custom serialization: 12
INFO - mosquito: deserialized: 120
INFO - mosquito: Success: task custom_serializers_job<1642475392145:418> finished and took 17.0µs
INFO - mosquito: Running task rate_limited_job<1642475392146:766> from rate_limited_job
INFO - mosquito: mosquito:rate_limit:rate_limited_job
INFO - mosquito: Success: task rate_limited_job<1642475392146:766> finished and took 37.0µs
INFO - mosquito: Running task custom_serializers_job<1642475392145:480> from custom_serializers_job
INFO - mosquito: using custom serialization: 525600
INFO - mosquito: deserialized: 5256000
INFO - mosquito: Success: task custom_serializers_job<1642475392145:480> finished and took 25.0µs
INFO - mosquito: Running task rate_limited_job<1642475392146:571> from rate_limited_job
INFO - mosquito: mosquito:rate_limit:rate_limited_job
INFO - mosquito: Success: task rate_limited_job<1642475392146:571> finished and took 25.0µs
INFO - mosquito: Running task rate_limited_job<1642475392147:32> from rate_limited_job
WARN - mosquito: Failure: task rate_limited_job<1642475392147:32> failed, taking 34.0µs and will run again in 00:00:02 (at 2022-01-18 03:09:54 UTC)
INFO - mosquito: Running task periodically_puts<1642475392149:419> from periodically_puts
INFO - mosquito: Hello from PeriodicallyPuts

This defeats some of the purposes of using Log because messages cannot be filtered by topic easily. Ideally mosquito should be one of:

  • mosquito.runner
  • mosquito.job
  • mosquito.job.{job name}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant