We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/ThrunGroup/BanditPAM/blob/main/src/main.cpp#L40-L42 contains a bug; it assumes that the single character after the L is the norm; this creates an error, for example, when the loss is L15, or if the name of a loss function happens to start with L.
L
L15
Instead, we should check specifically for the form L\d* and get all characters except the first in that case.
L\d*
The text was updated successfully, but these errors were encountered:
Closes #37
f28d309
Parsing loss function using all digits. Fixes #37
868cf9b
03f9335
Add back loss parsing in setLossFn. Fixes #37
3ac2ba2
7e1ba6c
Merge pull request #50 from ThrunGroup/loss_parsing
c3f2c77
Fixes #37
mailology
No branches or pull requests
https://github.com/ThrunGroup/BanditPAM/blob/main/src/main.cpp#L40-L42 contains a bug; it assumes that the single character after the
L
is the norm; this creates an error, for example, when the loss isL15
, or if the name of a loss function happens to start withL
.Instead, we should check specifically for the form
L\d*
and get all characters except the first in that case.The text was updated successfully, but these errors were encountered: