Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with loss parsing #37

Closed
motiwari opened this issue Apr 27, 2021 · 0 comments
Closed

Bug with loss parsing #37

motiwari opened this issue Apr 27, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@motiwari
Copy link
Owner

https://github.com/ThrunGroup/BanditPAM/blob/main/src/main.cpp#L40-L42 contains a bug; it assumes that the single character after the L is the norm; this creates an error, for example, when the loss is L15, or if the name of a loss function happens to start with L.

Instead, we should check specifically for the form L\d* and get all characters except the first in that case.

@motiwari motiwari changed the title Bug with log parsing Bug with loss parsing Apr 27, 2021
mailology pushed a commit that referenced this issue May 28, 2021
@motiwari motiwari added the bug Something isn't working label May 28, 2021
@motiwari motiwari added this to the 6-14-21 Milestone milestone May 28, 2021
motiwari added a commit that referenced this issue Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants