Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick bug fix? #18

Open
mosaiceye opened this issue Aug 15, 2017 · 1 comment
Open

Quick bug fix? #18

mosaiceye opened this issue Aug 15, 2017 · 1 comment

Comments

@mosaiceye
Copy link

https://github.com/ClaudiuCreanga/magento2-store-locator-stockists-extension/blob/8bf464f7f380d74c7e0c3f4f9226eb2aa4774d26/src/view/frontend/web/js/limesharp_stockists.js#L106

Nice extension, I just noticed a quick bug @106:

BEFORE:
contentString += '<p class="ask-for-directions get-directions" data-directions="DRIVING">Get Directions</p>';

AFTER:
contentString += '<p class="ask-for-directions get-directions" data-directions="DRIVING"><a href="http://maps.google.com/maps?saddr=&daddr='+marker.getPosition().lat()+','+marker.getPosition().lng()+'" target="_blank">Get Directions</a></p>';

@ClaudiuCreanga
Copy link
Collaborator

@mosaiceye Thanks for this. Not sure if this is a bug. Your edit opens the directions on google maps or the maps application on mobile. As it is it works by displaying the directions on the website, not leaving the website. I agree that for mobile this is not ideal so probably it should be only for mobile..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants