New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in code: choose_optimal_reference.R #27

Closed

hebertodelrio opened this issue Jun 13, 2022 · 1 comment

hebertodelrio commented Jun 13, 2022 •

edited

Loading

In the file choose_optimal_reference.R on the line 47 inside the function choose_optimal_reference
it reads:

index <- which(min(x[["score"]]/x[["n_peaks"]]) == min(x[["score"]]/x[["n_peaks"]]))

but I believe it should read:

index <- which(x[["score"]]/x[["n_peaks"]] == min(x[["score"]]/x[["n_peaks"]]))

otherwise index will always contain 1

Owner

mottensmann commented Jun 19, 2022

Many thanks for pointing out this error! I will update the code accordingly, and push a new release to GitHub and CRAN soon.

mottensmann closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment