Problem in _setup() on non-English OS

[pochamarui]

There's a problem in that code in 1.2.6:

 def _warn_import_error(exc):
        [...]
        _warn("ImportError: %s" % msg)

The _warn() call will throw a unicode-decode-error when run on a french OS, for instance:
<type 'exceptions.UnicodeDecodeError'> 'ascii' codec can't decode byte 0xe9 in position 59: ordinal not in range(128)

Possibly a missing .encode('utf-8') on msg?

[mottosso]

Thanks for reporting this @pochamarui!

I wonder, can it be as easy as putting this line at the top of the Qt.py Python file?

# -*- coding: utf-8 -*-

[pochamarui]

I don't have access to that machine at the moment, so I cannot currently test, but I think it will not work.

By the look of it, that string above is used so that unicode strings - written inside the python source file - can be handled correctly. In my case, the string is not in the source file, but returned by the OS.
It is part of the exception, and is not stored in the .py file

[mottosso]

Cool, no worries. Are you able to post the message here? I need some way of reproducing the error, ideally during the automated tests.

[pochamarui]

I asked a colleague with a French machine to do a few tests.
The error-message (obtained by writing it to a text file), is:

DLL load failed: Le module spécifié est introuvable.

Side-notes:

• isinstance(msg, str)
  returns true

• attempting to encode/decode msg to utf-8 , before passing it to warn(), failed

[friedererdmann]

Hey, ran into this today. I'm proposing the following:

def _setup(module, extras):
    """Install common submodules"""
    Qt.__binding__ = module.__name__

    def _warn_import_error(exc):
        if sys.version_info < (3, 0):
            if isinstance(exc, unicode):
                exc = exc.encode('ascii', 'replace')
        msg = str(exc)
        if "No module named" in msg:
            return
        _warn("ImportError: %s" % msg)

[...]

I can only see the issue in Python 2, therefore the version check.
You can test the behavior:

import sys
text = str(u"DLL load failed : le module spécifié est introuvable.".encode('ascii', 'replace'))
>> b'DLL load failed : le module sp?cifi? est introuvable.'

[mottosso]

Seems good to me. Could you put it in a PR?