Actual fix for #346 - unroll of #357 #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python logic: in previous version, the declaration of unicode = str in the Python 3 exclusive path made the Python 2 code fail, as unicode was now seen as an undeclared variable (as it had been declared in the Python 3 code, so Python assumes it is no longer the build-in type). This version uses string comparison to work around the issue of the type.__name__, which seems to be the only way to work around this issue.
houndci-bot
reviewed
Jul 16, 2021
|
Brilliant, great work @friedererdmann. Happy for me to merge and release this? |
|
Yes, this should be safe to release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After much back and forth trying to pin point the issue for one of our French speaking users, I got around getting a French Windows PC and rolled back through all the changes made to fix #346 .
This resets
_setupand_warn_import_errorswhich I thought were the original culprits. However, the issue is specific to how 3Ds Max (and other Autodesk DCCs) use unicode strings in stdout.This change moves catching the unicode error to
_warnand encodes the message using the preferred locale, resulting in more readable code and a more readable error message.I updated the test to test this without the need for a full setup.