Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New method for body + query params #46

Closed
coleshaw opened this issue May 22, 2020 · 1 comment
Closed

New method for body + query params #46

coleshaw opened this issue May 22, 2020 · 1 comment
Assignees
@coleshaw
Labels
enhancement

Comments

@coleshaw
Copy link
Collaborator

Turns out it's really difficult to encode complex hashes (like an array of multiple revision hashes!) into URL query parameters ... see this discussion / question on SO. Trying to decode the revisions on Metis became a nightmare. So I think we need a new method for Etna Client that handles both body and query parameters. Query parameters for the HMAC calculations, and body parameters for data.
@coleshaw coleshaw self-assigned this May 22, 2020
@coleshaw
Copy link
Collaborator Author

Okay, I've concluded this is not really needed .. seems to work okay if you JSON stringify the revisions value first. Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleshaw coleshaw

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coleshaw