Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMAC signature text-to-sign should use JSON for headers #48

Closed
coleshaw opened this issue May 26, 2020 · 0 comments · Fixed by #50
Closed

HMAC signature text-to-sign should use JSON for headers #48

coleshaw opened this issue May 26, 2020 · 0 comments · Fixed by #50
Assignees
@coleshaw

Comments

@coleshaw
Copy link
Collaborator

Doing a customized stringify of the headers Hash doesn't quite work as expected, because .join on Arrays is recursive...so we're getting unexpected behavior when signing array bodies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleshaw coleshaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue48 49 fix hmac signing mountetna/etna
1 participant
@coleshaw