Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llrb.js – Remove Gets Values Mixed Up #5

Open
bherschb opened this issue Feb 9, 2019 · 2 comments
Open

llrb.js – Remove Gets Values Mixed Up #5

bherschb opened this issue Feb 9, 2019 · 2 comments

Comments

@bherschb
Copy link

bherschb commented Feb 9, 2019

Thanks for this project. Good stuff. I noticed one small defect, which has a quick fix:

There is a minor typo in llrb.js, in the remove(h, key, compare) method, line 111 currently, where it uses “val”, instead of “value”. This results in the value of the removed node being retained, and the value of another node being lost. Easy fix: just change the two instances of “val” on that line to “value”. Seems to work great after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@bherschb and others