Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

[Feature Request] Make a note in setup for SOLC_EXE for solidity tests #23

Open
gregnazario opened this issue Apr 14, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@gregnazario
Copy link
Collaborator

🚀 Feature Request

Make a note in setup for SOLC_EXE for solidity tests

Motivation

Is your feature request related to a problem? Please describe.
I was getting really confused why it was always telling me SOLC_EXE couldn't be found, then I realized you needed the solidity compiler for some compatibility tests. It's a little weird, and just would be great to call out / make these tests run separately when I just do cargo test.

If I missed where this is mentioned in the docs lmk.

@gregnazario gregnazario added the enhancement New feature or request label Apr 14, 2022
@wrwg
Copy link
Member

wrwg commented Apr 14, 2022

Like for the prover, if the right tool is not found (i.e. SOLC_EXE is undefined), we should have a graceful error message pointing to hat dev_setup,sh -dp should be run. We could also check for the version, as we do e.g. here for the prover:

https://github.com/move-language/move/blob/main/language/move-prover/boogie-backend/src/options.rs#L253

jiangying000 added a commit to jiangying000/move that referenced this issue Sep 21, 2022
…sts (move-language#23)

* long addr

* format

* update

* use char

* comment unused

* ir-compiler test

* some move-package tests

* fix tests/test_sources/resolution/basic_no_deps_address_assigned/Move.exp

* typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants