Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken box-ray intersection #68

Closed
LeroyR opened this issue May 5, 2017 · 4 comments
Closed

Broken box-ray intersection #68

LeroyR opened this issue May 5, 2017 · 4 comments

Comments

@LeroyR
Copy link
Contributor

LeroyR commented May 5, 2017

Had some cases where the ray/box intersection was broken.

#67
@LeroyR LeroyR mentioned this issue Nov 29, 2017
Merged
@davetcoleman
Copy link
Member

This is confusing how you just have a single number for the description, can you please elaborate?

@LeroyR
Copy link
Contributor Author

LeroyR commented Dec 4, 2017 •
edited

#67 is a link to the pull request which shows that raytracing is currently broken
https://github.com/ros-planning/geometric_shapes/pull/67

@LeroyR
Copy link
Contributor Author

LeroyR commented Dec 4, 2017 •
edited

Again,

TEST(BoxRayIntersection, BrokenRay2)

box (x=0.2)
pose x=0.45
-> box X between 0.25 and 0.65
with ray from x=0 and direction x=0 should not intersect.

EXPECT_FALSE(intersect)

Results in

[ FAILED ] BoxRayIntersection.BrokenRay2

@rhaschke
Copy link
Contributor

rhaschke commented Jan 9, 2018

Closed via #73

@rhaschke rhaschke closed this as completed Jan 9, 2018
@skohlbr skohlbr mentioned this issue May 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davetcoleman @rhaschke @LeroyR