Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for broken raytracing #67

Closed
wants to merge 1 commit into from
Closed

Conversation

LeroyR
Copy link
Contributor

@LeroyR LeroyR commented May 5, 2017

Some random rays that have broken box intersections

@LeroyR LeroyR mentioned this pull request May 5, 2017
@davetcoleman
Copy link
Member

Travis fails on this test?

@v4hn
Copy link
Contributor

v4hn commented May 8, 2017

@LeroyR Are you sure these tests should succeed? I didn't verify the math.
If you are, any idea why the raytracing could fail?
It's a simple enough operation, i.e. it should work about always, or never.
And nobody else complained about this before. I concede though, that this doesn't mean that it actually works...

@LeroyR
Copy link
Contributor Author

LeroyR commented May 8, 2017

Yes, im pretty sure these test should succeed. I use this to generate maps for camera positions that are able to view a shelf of some bookcase and found good poses 'behind' the bookcase.
e.g. BrokenRay2 box x=0.2 at pose x=0.45 with ray from x=0 and direction x=0 should not intersect.

I dont know why the current algorithm fails. I replaced the code with google and it worked so i did not bother.

@davetcoleman
Copy link
Member

Does #73 replace this?

@LeroyR
Copy link
Contributor Author

LeroyR commented Dec 14, 2017

merged into #73

@LeroyR LeroyR closed this Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants