Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log function deprecation warnings. #72

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

mikepurvis
Copy link
Contributor

Closes #71.

@mikepurvis mikepurvis changed the title Fix log warnings. Fix log function deprecation warnings. Oct 20, 2017
@racko
Copy link

racko commented Jan 4, 2018

Since the release of console_bridge 0.4.0 (ros/console_bridge@c227ae0), these have turned from deprecation warnings into build errors:

.../geometric_shapes-release-release-lunar-geometric_shapes-0.5.3-0/src/body_operations.cpp:62:7: error: ‘logError’ was not declared in this scope
       logError("Creating body from shape: Unknown shape type %d", (int)shape->type);

Also, it seems that the change needs an update since your change does not touch body_operations.cpp, which has a number of logError occurrences.

Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants