Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad tracking on moveit.ros.org #232

Closed
tfoote opened this issue Nov 21, 2018 · 3 comments
Closed

ad tracking on moveit.ros.org #232

tfoote opened this issue Nov 21, 2018 · 3 comments

Comments

@tfoote
Copy link
Contributor

tfoote commented Nov 21, 2018

Browsing the site I noticed that my browser is blocking doubleclick on moveit.ros.org

image

https://gist.github.com/tfoote/3dfcbfc00f9775a55335b6e5a3d6f968

It seems to be related to an embedded video player.
tfoote added a commit that referenced this issue Nov 21, 2018
@tfoote
Switch to youtube-nocookie embed url for all urls
afc7adb 
Potentially helping with #232

https://www.ghacks.net/2018/05/23/why-you-should-always-use-youtubes-privacy-enhanced-mode/
@tfoote tfoote mentioned this issue Nov 21, 2018
Merged
@davetcoleman
Copy link
Member

@L4co77 added that, perhaps he can comment?

@L4co77
Copy link
Collaborator

L4co77 commented Nov 21, 2018

Yep,it's just a detection of Adblock or any chrome extensions for blocking advertisements.

davetcoleman pushed a commit that referenced this issue Nov 21, 2018
@tfoote @davetcoleman
Switch to youtube-nocookie embed url for all urls (#233)
db97bb9 
Potentially helping with #232

https://www.ghacks.net/2018/05/23/why-you-should-always-use-youtubes-privacy-enhanced-mode/
@davetcoleman
Copy link
Member

This is an old issue addressed by #233

Closing

@davetcoleman davetcoleman mentioned this issue Nov 27, 2019
Merged
davetcoleman pushed a commit to davetcoleman/moveit.ros.org that referenced this issue Aug 19, 2020
@tfoote @davetcoleman
Switch to youtube-nocookie embed url for all urls (moveit#233)
919e10d 
Potentially helping with moveit#232

https://www.ghacks.net/2018/05/23/why-you-should-always-use-youtubes-privacy-enhanced-mode/
Former-commit-id: db97bb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tfoote @davetcoleman @L4co77