-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
related_projects: add a page for related projects #209
Conversation
Looks that the CI system failed to connect to an external website required from the existing codes. |
I fixed the broken link this morning, just retriggered this job |
This list represents what came to my mind when I wrote the issue, it's by no means exhaustive. Also, it would be really great if we could have a single picture associated with each project. |
Added in the revision.
Some projects come with visualization results, the others not. Does it make sense to add an icon of the project owner to each project? See the update in new revision |
On Thu, Oct 25, 2018 at 04:30:53AM -0700, Sharron LIU wrote:
Some projects come with visualization results, the others not.
I believe the project owners could provide illustrations if they are interested.
Does it make sense to add an icon of the project owner to each project?
See the update in new revision #4ad2c74
I don't really like that.
I was thinking of bigger images next to or below the text, not next to the header.
E.g., for moveit_grasps I would like to add https://raw.githubusercontent.com/PickNikRobotics/moveit_grasps/kinetic-devel/resources/demo.png
If you don't find an image in a project, you could add a blank placeholder (a questionmark, a grey frame, ...).
For the projects by TAMS, I can probably provide images at a later point in time.
|
Updated, with a "place_holder" image for projects to add picture later. |
Added a webpage collection of MoveIt! related rojects/plugins. fix issue moveit#164 fix issue moveit/moveit#1114 Signed-off-by: Sharron LIU <sharron.liu@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Co-Authored-By: sharronliu <sharron.liu@intel.com>
The wordpress folder is deprecated. So moving pictures to "asserts/images". Signed-off-by: Sharron LIU <sharron.liu@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can certainly iterate on this page in future PRs, but this is awesome thanks!
i just realized this isn't enough to get this page visible on the website. instead, we need to add this to the main menus also, here: https://github.com/ros-planning/moveit.ros.org/blob/gh-pages/_includes/nav-bar.html#L47 |
Addressed in #225 |
* related_projects: add a page for related projects Added a webpage collection of MoveIt! related rojects/plugins. fix issue moveit#164 fix issue moveit/moveit#1114 Signed-off-by: Sharron LIU <sharron.liu@intel.com> * test "apply suggestion" from PR reviewers Co-Authored-By: sharronliu <sharron.liu@intel.com> * related_projects: moved img under /assets/images The wordpress folder is deprecated. So moving pictures to "asserts/images". Signed-off-by: Sharron LIU <sharron.liu@intel.com> Former-commit-id: 825be7a
Added a webpage collection of MoveIt! related rojects/plugins.
fix issue #164
fix issue moveit/moveit#1114
Signed-off-by: Sharron LIU sharron.liu@intel.com