Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

related_projects: add a page for related projects #209

Merged
merged 3 commits into from
Oct 26, 2018

Conversation

sharronliu
Copy link
Contributor

Added a webpage collection of MoveIt! related rojects/plugins.

fix issue #164
fix issue moveit/moveit#1114

Signed-off-by: Sharron LIU sharron.liu@intel.com

@sharronliu
Copy link
Contributor Author

Looks that the CI system failed to connect to an external website required from the existing codes.

@davetcoleman
Copy link
Member

I fixed the broken link this morning, just retriggered this job

documentation/index.markdown Outdated Show resolved Hide resolved
documentation/related_projects/index.markdown Outdated Show resolved Hide resolved
documentation/related_projects/index.markdown Outdated Show resolved Hide resolved
documentation/related_projects/index.markdown Outdated Show resolved Hide resolved
documentation/related_projects/index.markdown Outdated Show resolved Hide resolved
documentation/related_projects/index.markdown Outdated Show resolved Hide resolved
documentation/related_projects/index.markdown Outdated Show resolved Hide resolved
documentation/related_projects/index.markdown Outdated Show resolved Hide resolved
documentation/related_projects/index.markdown Outdated Show resolved Hide resolved
@v4hn
Copy link
Contributor

v4hn commented Oct 24, 2018

This list represents what came to my mind when I wrote the issue, it's by no means exhaustive.
Please add a proper statement in the beginning to clarify this and ask for pull-requests in this repository to add other projects.

Also, it would be really great if we could have a single picture associated with each project.
Might be a bit tricky for some, but then just add a place holder for those for now.

@sharronliu
Copy link
Contributor Author

sharronliu commented Oct 25, 2018

This list represents what came to my mind when I wrote the issue, it's by no means exhaustive.
Please add a proper statement in the beginning to clarify this and ask for pull-requests in this repository to add other projects.

Added in the revision.

Also, it would be really great if we could have a single picture associated with each project.
Might be a bit tricky for some, but then just add a place holder for those for now.

Some projects come with visualization results, the others not. Does it make sense to add an icon of the project owner to each project? See the update in new revision

@v4hn
Copy link
Contributor

v4hn commented Oct 25, 2018 via email

@sharronliu
Copy link
Contributor Author

If you don't find an image in a project, you could add a blank placeholder (a questionmark, a grey frame, ...). For the projects by TAMS, I can probably provide images at a later point in time.

Updated, with a "place_holder" image for projects to add picture later.

Added a webpage collection of MoveIt! related rojects/plugins.

fix issue moveit#164
fix issue moveit/moveit#1114

Signed-off-by: Sharron LIU <sharron.liu@intel.com>
Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

documentation/related_projects/index.markdown Outdated Show resolved Hide resolved
documentation/related_projects/index.markdown Outdated Show resolved Hide resolved
documentation/source-code-api/index.markdown Show resolved Hide resolved
davetcoleman and others added 2 commits October 26, 2018 12:17
Co-Authored-By: sharronliu <sharron.liu@intel.com>
The wordpress folder is deprecated.
So moving pictures to "asserts/images".

Signed-off-by: Sharron LIU <sharron.liu@intel.com>
Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can certainly iterate on this page in future PRs, but this is awesome thanks!

@davetcoleman davetcoleman merged commit 825be7a into moveit:gh-pages Oct 26, 2018
@davetcoleman
Copy link
Member

@davetcoleman
Copy link
Member

Addressed in #225

davetcoleman pushed a commit to davetcoleman/moveit.ros.org that referenced this pull request Aug 19, 2020
* related_projects: add a page for related projects

Added a webpage collection of MoveIt! related rojects/plugins.

fix issue moveit#164
fix issue moveit/moveit#1114

Signed-off-by: Sharron LIU <sharron.liu@intel.com>

* test "apply suggestion" from PR reviewers

Co-Authored-By: sharronliu <sharron.liu@intel.com>

* related_projects: moved img under /assets/images

The wordpress folder is deprecated.
So moving pictures to "asserts/images".

Signed-off-by: Sharron LIU <sharron.liu@intel.com>

Former-commit-id: 825be7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants