Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: unable to warn user when the service is not available. #2064

Closed
yeshwanths88 opened this issue May 7, 2020 · 2 comments · Fixed by #2077
Closed

Bug: unable to warn user when the service is not available. #2064

yeshwanths88 opened this issue May 7, 2020 · 2 comments · Fixed by #2077

Comments

@yeshwanths88
Copy link
Contributor

yeshwanths88 commented May 7, 2020

https://github.com/ros-planning/moveit/blob/efa7fdca8a6999dbfcc28171b83deb67b258438a/moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp#L719

Since the check is for the srvice client object and not for the service itself, eventhough a service is not available, it is not caught here. And the user gets wrong error message: "Grasp planning failed. Unable to pick."
But in reality the service itself is not available.
Alternatively we could check for the service:
if (!plan_grasps_service_.waitForExistence(ros::Duration(2)))

@welcome
Copy link

welcome bot commented May 7, 2020

Thanks for reporting an issue. Because we're a volunteer community, providing a pull request with suggested changes is always welcomed.

@v4hn
Copy link
Contributor

v4hn commented May 11, 2020

I proposed moveit/moveit_msgs#73 to be able to differentiate between service failure and planning failure in this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants