Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait and check for the grasp service #2065

Closed

Conversation

yeshwanths88
Copy link
Contributor

@yeshwanths88 yeshwanths88 commented May 7, 2020

Description

#2064

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented May 7, 2020

Thanks for helping in improving MoveIt and open source robotics!

@codecov-io
Copy link

Codecov Report

Merging #2065 into master will increase coverage by 0.37%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
+ Coverage   54.16%   54.54%   +0.37%     
==========================================
  Files         328      328              
  Lines       25624    25624              
==========================================
+ Hits        13880    13977      +97     
+ Misses      11744    11647      -97     
Impacted Files Coverage Δ
.../move_group_interface/src/move_group_interface.cpp 40.77% <0.00%> (+3.66%) ⬆️
...ove_group_interface/src/wrap_python_move_group.cpp 43.03% <0.00%> (+11.07%) ⬆️
...s/include/moveit/py_bindings_tools/serialize_msg.h 80.00% <0.00%> (+80.00%) ⬆️
.../include/moveit/py_bindings_tools/py_conversions.h 86.66% <0.00%> (+86.66%) ⬆️
...ls/include/moveit/py_bindings_tools/gil_releaser.h 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa7fdc...b627e61. Read the comment docs.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change. It is always easy to review small changes.

@@ -716,7 +716,7 @@ class MoveGroupInterface::MoveGroupInterfaceImpl

MoveItErrorCode planGraspsAndPick(const moveit_msgs::CollisionObject& object, bool plan_only = false)
{
if (!plan_grasps_service_)
if (!plan_grasps_service_.waitForExistence(ros::Duration(0.2)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you pick this duration for the wait? Should it not just be 0 to make it fail right away if the service is not available?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!plan_grasps_service_.waitForExistence(ros::Duration(0.2)))
if (!plan_grasps_service_.exists())

@v4hn
Copy link
Contributor

v4hn commented May 11, 2020

Thank you for your contribution @yeshwanths88 .

#2077 supersedes this request and includes this commit and more improvements.

@v4hn v4hn closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants