-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait and check for the grasp service #2065
Conversation
Thanks for helping in improving MoveIt and open source robotics! |
Codecov Report
@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
+ Coverage 54.16% 54.54% +0.37%
==========================================
Files 328 328
Lines 25624 25624
==========================================
+ Hits 13880 13977 +97
+ Misses 11744 11647 -97
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change. It is always easy to review small changes.
@@ -716,7 +716,7 @@ class MoveGroupInterface::MoveGroupInterfaceImpl | |||
|
|||
MoveItErrorCode planGraspsAndPick(const moveit_msgs::CollisionObject& object, bool plan_only = false) | |||
{ | |||
if (!plan_grasps_service_) | |||
if (!plan_grasps_service_.waitForExistence(ros::Duration(0.2))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you pick this duration for the wait? Should it not just be 0 to make it fail right away if the service is not available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!plan_grasps_service_.waitForExistence(ros::Duration(0.2))) | |
if (!plan_grasps_service_.exists()) |
Thank you for your contribution @yeshwanths88 . #2077 supersedes this request and includes this commit and more improvements. |
Description
#2064
Checklist