Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing RViz dependency in MSA template #2455

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Dec 8, 2020

Description

Adds a missing dependency on RViz to the MSA template. If not, the package will fail roslaunch checks if they are added.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@DLu DLu requested a review from rhaschke as a code owner December 8, 2020 19:30
@felixvd felixvd changed the title Missing RViz depenency in MSA template Missing RViz dependency in MSA template Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #2455 (00aca0c) into master (bdd4bde) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2455      +/-   ##
==========================================
+ Coverage   60.24%   60.34%   +0.10%     
==========================================
  Files         351      351              
  Lines       26435    26455      +20     
==========================================
+ Hits        15923    15961      +38     
+ Misses      10512    10494      -18     
Impacted Files Coverage Δ
..._interface/src/detail/constrained_goal_sampler.cpp 72.50% <0.00%> (-10.00%) ⬇️
...bot_state/include/moveit/robot_state/robot_state.h 90.91% <0.00%> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.55% <0.00%> (+0.45%) ⬆️
...on/pick_place/src/approach_and_translate_stage.cpp 72.96% <0.00%> (+0.82%) ⬆️
moveit_core/utils/src/robot_model_test_utils.cpp 73.15% <0.00%> (+1.05%) ⬆️
...kinematic_constraints/src/kinematic_constraint.cpp 74.63% <0.00%> (+1.24%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 74.47% <0.00%> (+2.13%) ⬆️
...e/src/parameterization/model_based_state_space.cpp 72.80% <0.00%> (+2.40%) ⬆️
moveit_core/robot_model/src/joint_model_group.cpp 65.44% <0.00%> (+2.47%) ⬆️
...eit_ros/manipulation/pick_place/src/pick_place.cpp 92.23% <0.00%> (+3.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd4bde...00aca0c. Read the comment docs.

@DLu
Copy link
Contributor Author

DLu commented Dec 17, 2020

I also think moveit_simple_controller_manager should have a dependency here. Can add it if this is approved.

@rhaschke
Copy link
Contributor

I also think moveit_simple_controller_manager should have a dependency here. Can add it if this is approved.

Yes, this as well as moveit_fake_controller_manager is needed.

@DLu
Copy link
Contributor Author

DLu commented Dec 18, 2020

@DLu
Copy link
Contributor Author

DLu commented Dec 21, 2020

Good to merge then?

@JafarAbdi JafarAbdi merged commit da926ac into moveit:master Dec 21, 2020
@tylerjw tylerjw mentioned this pull request Apr 9, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Apr 29, 2021
@tylerjw tylerjw mentioned this pull request Apr 29, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request May 3, 2021
tylerjw pushed a commit that referenced this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants