Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subframes test #2488

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Conversation

bostoncleek
Copy link
Contributor

@bostoncleek bostoncleek commented Jan 14, 2021

Sometime the SubframesTests will fail. Planning on this particular problem
takes ~10s and the allotted planning time for move_group was set to 10s.
The planning time has been increased to 30s and the target pose offset was
increased from 1cm to 5cm. This should make the planning problem easier to
solve and therefore more likely to pass the test.

The result from the test is bellow: @tylerjw
subframes

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Sometime the SubframesTests will fail. Planning on this particular problem
takes ~10s and the allotted planning time for move_group was set to 10s.
The planning time has been increased to 30s and the target pose offset was
increased from 1cm to 5cm. This should make the planning problem easier to
solve and therefore more likely to pass the test.
@tylerjw tylerjw added this to Needs triage in MoveIt & Co via automation Jan 14, 2021
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you. I tested this locally and it works. This should make CI more reliable.

@tylerjw tylerjw moved this from Needs triage to High priority in MoveIt & Co Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #2488 (626ed9c) into master (a9c8f93) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
- Coverage   60.24%   60.22%   -0.02%     
==========================================
  Files         351      351              
  Lines       26477    26477              
==========================================
- Hits        15948    15942       -6     
- Misses      10529    10535       +6     
Impacted Files Coverage Δ
...meterization/work_space/pose_model_state_space.cpp 83.09% <0.00%> (-1.47%) ⬇️
...ipulation/pick_place/src/manipulation_pipeline.cpp 72.35% <0.00%> (-1.06%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 67.68% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c8f93...626ed9c. Read the comment docs.

Copy link
Contributor

@mamoll mamoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30s seems like a long time to plan for a problem without obstacles, but that seems like a separate issue...

@tylerjw
Copy link
Member

tylerjw commented Jan 15, 2021

30s seems like a long time to plan for a problem without obstacles, but that seems like a separate issue...

the travis machines are sad

@tylerjw tylerjw merged commit 664ae01 into moveit:master Jan 15, 2021
MoveIt & Co automation moved this from High priority to Closed Jan 15, 2021
@tylerjw tylerjw mentioned this pull request Apr 9, 2021
@tylerjw tylerjw mentioned this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MoveIt & Co
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants