-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update subframes test #2488
Update subframes test #2488
Conversation
Sometime the SubframesTests will fail. Planning on this particular problem takes ~10s and the allotted planning time for move_group was set to 10s. The planning time has been increased to 30s and the target pose offset was increased from 1cm to 5cm. This should make the planning problem easier to solve and therefore more likely to pass the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you. I tested this locally and it works. This should make CI more reliable.
Codecov Report
@@ Coverage Diff @@
## master #2488 +/- ##
==========================================
- Coverage 60.24% 60.22% -0.02%
==========================================
Files 351 351
Lines 26477 26477
==========================================
- Hits 15948 15942 -6
- Misses 10529 10535 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
30s seems like a long time to plan for a problem without obstacles, but that seems like a separate issue...
the travis machines are sad |
Sometime the SubframesTests will fail. Planning on this particular problem
takes ~10s and the allotted planning time for move_group was set to 10s.
The planning time has been increased to 30s and the target pose offset was
increased from 1cm to 5cm. This should make the planning problem easier to
solve and therefore more likely to pass the test.
The result from the test is bellow: @tylerjw
Checklist