bugfix backport #2098
Closed
bugfix backport #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moveit#2041) configure travis to report success before code-coverage finishes
Test passes when relaxing the acceptance region to 1e-6
* add tests for move_group tutorials * easier to reach joint positions for less flaky test * allow more time for planning * remove move to start pose * reduce epsilon to 1e-5
Some auxiliary PRAs can create additional waypoints, so time parameterization must run *after* them on return of a successful plan, which means it has to be loaded *before* them in the PRA chain. Additionally, constraint names have to be resolved *before* fixing the input state w.r.t. them. Look up the source code and documentation if you don't believe it.
Sure, some of them will probably almost never be used, but I prefer full flexibility over missing an intuitive interface in the long run. Before this patch it was impossible to remove dynamics information from a state once it was added.
.. as they might be generated by a planner when the goal is already reached.
Co-authored by v4hn
Unify the checks, they exist for all other actions.
v4hn
added
melodic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2080 with a private remote branch pushable by all maintainers.
Description
These are bug fixes for merging into melodic_devel for the upcoming release.
Merge or rebase should be done to preserve the history of these commits.
reviewed-for-backportshould be fast-forwarded to 091bdfb after merging this.