Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up TrajectoryExecutionManager API: remove unused code #3178

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

cambel
Copy link
Contributor

@cambel cambel commented Jul 25, 2022

Part of #3156.

The idea is to first clean up the unused code of the API before adding new futures to handle the simultaneous execution of trajectories.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #3178 (8e37718) into master (79626a6) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
+ Coverage   61.71%   61.95%   +0.24%     
==========================================
  Files         375      375              
  Lines       33270    33135     -135     
==========================================
- Hits        20530    20524       -6     
+ Misses      12740    12611     -129     
Impacted Files Coverage Δ
moveit_ros/planning/moveit_cpp/src/moveit_cpp.cpp 68.51% <ø> (+1.07%) ⬆️
...y_execution_manager/trajectory_execution_manager.h 100.00% <ø> (ø)
...ution_manager/src/trajectory_execution_manager.cpp 60.55% <ø> (+7.45%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 71.91% <0.00%> (-1.65%) ⬇️
...on/pick_place/src/approach_and_translate_stage.cpp 75.16% <0.00%> (-0.60%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 77.91% <0.00%> (-0.37%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 81.00% <0.00%> (-0.29%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 81.77% <0.00%> (+1.77%) ⬆️
.../ompl_interface/src/detail/constrained_sampler.cpp 60.98% <0.00%> (+17.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79626a6...8e37718. Read the comment docs.

@simonschmeisser
Copy link
Contributor

Please add a note to MIGRATION.md explaining what's going on

Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was approved in yesterday's Maintainer Meeting.

@v4hn v4hn merged commit 24c18f6 into moveit:master Jul 29, 2022
@cambel cambel deleted the clean-tem-api branch August 1, 2022 00:20
Martin-Oehler added a commit to Martin-Oehler/moveit that referenced this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants