Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different packages for launch and config packages in generate_demo_launch #2647

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

forrest-rm
Copy link
Contributor

Description

When generating demo launch, allow for separate launch and config packages. If launch_package_path is not provided, default to moveit_config.package_path as previously done.

This removes the need to have identical duplicate launch files when testing multiple robots.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1fb4041) 50.91% compared to head (5390d89) 50.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2647      +/-   ##
==========================================
- Coverage   50.91%   50.90%   -0.01%     
==========================================
  Files         387      387              
  Lines       32430    32430              
==========================================
- Hits        16508    16504       -4     
- Misses      15922    15926       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr
Copy link
Contributor

sjahr commented Jan 11, 2024

Thank you!

@forrest-rm
Copy link
Contributor Author

@sjahr, would it be possible to back port this to the humble release branch as well. I originally tested it there.

@sjahr sjahr added the backport-humble Mergify label that triggers a PR backport to Humble label Jan 12, 2024
@sjahr
Copy link
Contributor

sjahr commented Jan 12, 2024

@sjahr, would it be possible to back port this to the humble release branch as well. I originally tested it there.

Since it does not break the API yes 👍 I've added the backport lable

@sjahr sjahr merged commit 627e95a into moveit:main Jan 12, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Jan 12, 2024
…o_launch (#2647)

* �[200~use differnt packages for launch and config packages

* add to function description

(cherry picked from commit 627e95a)
henningkayser pushed a commit that referenced this pull request Mar 14, 2024
…o_launch (backport #2647) (#2650)

(cherry picked from commit 627e95a)

Co-authored-by: Forrest Rogers-Marcovitz <39061824+forrest-rm@users.noreply.github.com>
Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants