Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip flaky PSM launch test #2822

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Skip flaky PSM launch test #2822

merged 1 commit into from
Apr 30, 2024

Conversation

EzraBrooks
Copy link
Member

Description

Skips a PSM launch test that has failed in a number of branches, including #2740, that appears to be performance/latency-related.

Opened an issue #2821 to track re-enabling this once we track down why it's failing.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@EzraBrooks
Copy link
Member Author

confirmed skipped: https://github.com/moveit/moveit2/actions/runs/8900616735/job/24442567382?pr=2822#step:12:2864

@EzraBrooks EzraBrooks marked this pull request as ready for review April 30, 2024 20:02
@EzraBrooks EzraBrooks added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit f880329 Apr 30, 2024
4 of 9 checks passed
@EzraBrooks EzraBrooks deleted the skip-flaky-test branch April 30, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abishalini Abishalini Abishalini approved these changes

@henningkayser henningkayser Awaiting requested review from henningkayser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EzraBrooks @Abishalini