Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CallbackGroup in PlanningSceneMonitor #1312

Closed

Conversation

henningkayser
Copy link
Member

@henningkayser henningkayser commented Jun 2, 2022

Similar to #1305, this replaces the private node with a CallbackGroup. There are still some issues with the synced parameters that I need to look into before this is really ready. Also, the CallbackGroup should be applied to the CSM as well.

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #1312 (d6b9ed2) into main (cea5764) will increase coverage by 0.07%.
The diff coverage is 80.40%.

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   61.48%   61.55%   +0.07%     
==========================================
  Files         274      274              
  Lines       24940    24943       +3     
==========================================
+ Hits        15332    15351      +19     
+ Misses       9608     9592      -16     
Impacted Files Coverage Δ
...it/planning_scene_monitor/planning_scene_monitor.h 28.58% <ø> (ø)
...nning_scene_monitor/src/planning_scene_monitor.cpp 47.98% <80.40%> (+2.26%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.36% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea5764...d6b9ed2. Read the comment docs.

@tylerjw tylerjw marked this pull request as ready for review July 29, 2022 13:12
@JafarAbdi JafarAbdi self-assigned this Jul 29, 2022
@henningkayser henningkayser marked this pull request as draft July 29, 2022 15:43
@henningkayser
Copy link
Member Author

I switched this back to DRAFT because there are still runtime issues with parameter updates I need to look into first.

@tylerjw tylerjw assigned henningkayser and unassigned JafarAbdi Nov 18, 2022
@mergify
Copy link

mergify bot commented Nov 18, 2022

This pull request is in conflict. Could you fix it @henningkayser?

@tylerjw
Copy link
Member

tylerjw commented Nov 18, 2022

@henningkayser do you have some documentation you can link to I can read to better understand what the issues are here?

Is there some test I can run to see the issues you are experiencing with this change?

@mergify
Copy link

mergify bot commented May 8, 2023

This pull request is in conflict. Could you fix it @henningkayser?

1 similar comment
@mergify
Copy link

mergify bot commented Aug 11, 2023

This pull request is in conflict. Could you fix it @henningkayser?

@tylerjw
Copy link
Member

tylerjw commented Aug 23, 2023

There is a small conflict but it seems like we abandoned this work. I'll create a issue to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants