Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake_components -> mock_components #1426

Closed
wants to merge 1 commit into from

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Jul 12, 2022

Signed-off-by: Tyler Weaver tylerjw@gmail.com

Description

This was caused by a change in ros2_control: ros-controls/ros2_control@1967cfa

Depends on moveit/moveit_resources#147

Signed-off-by: Tyler Weaver <tylerjw@gmail.com>
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1426 (3a13c50) into main (4597319) will decrease coverage by 4.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
- Coverage   50.85%   45.87%   -4.97%     
==========================================
  Files         381      367      -14     
  Lines       31735    30648    -1087     
==========================================
- Hits        16135    14057    -2078     
- Misses      15600    16591     +991     
Impacted Files Coverage Δ
...oveit_servo/include/moveit_servo/collision_check.h 0.00% <0.00%> (-100.00%) ⬇️
...veit_servo/include/moveit_servo/servo_parameters.h 0.00% <0.00%> (-100.00%) ⬇️
...line_signal_smoothing/src/smoothing_base_class.cpp 0.00% <0.00%> (-100.00%) ⬇️
...oveit/online_signal_smoothing/butterworth_filter.h 0.00% <0.00%> (-100.00%) ⬇️
.../collision_plugin_loader/collision_plugin_loader.h 0.00% <0.00%> (-100.00%) ⬇️
...or/src/current_state_monitor_middleware_handle.cpp 0.00% <0.00%> (-88.23%) ⬇️
moveit_ros/moveit_servo/src/collision_check.cpp 0.00% <0.00%> (-86.15%) ⬇️
moveit_ros/moveit_servo/src/servo.cpp 0.00% <0.00%> (-75.00%) ⬇️
moveit_ros/moveit_servo/src/servo_calcs.cpp 0.00% <0.00%> (-66.22%) ⬇️
...ude/moveit/robot_model_loader/robot_model_loader.h 42.86% <0.00%> (-57.14%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4597319...3a13c50. Read the comment docs.

@tylerjw
Copy link
Member Author

tylerjw commented Jul 12, 2022

Closing as I pushed the change for this into #1422

@tylerjw tylerjw closed this Jul 12, 2022
@tylerjw tylerjw deleted the mock_components branch July 12, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant