Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node logging in warehouse save_as_text #2435

Closed

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Oct 11, 2023

Description

#2434

@tylerjw tylerjw added backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e7577ca) 50.37% compared to head (493b0c2) 50.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2435      +/-   ##
==========================================
+ Coverage   50.37%   50.87%   +0.50%     
==========================================
  Files         385      386       +1     
  Lines       31829    32000     +171     
==========================================
+ Hits        16031    16276     +245     
+ Misses      15798    15724      -74     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tylerjw
Copy link
Member Author

tylerjw commented Oct 12, 2023

Closing in favor of #2445

@tylerjw tylerjw closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant