Port #3464 from MoveIt1 #2456
Merged
Port #3464 from MoveIt1 #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2456 +/- ##
==========================================
+ Coverage 50.46% 50.81% +0.35%
==========================================
Files 385 391 +6
Lines 31831 32125 +294
==========================================
+ Hits 16061 16321 +260
- Misses 15770 15804 +34
☔ View full report in Codecov by Sentry. |
cherry-pick of moveit/moveit#3464
Doesn't work because previous=0 for all recursively called functions.
rhaschke
force-pushed
the
fix-add-path-index
branch
from
0e44397
to
ce8ee9c
Compare
sjahr
approved these changes
Oct 17, 2023
| #include <moveit/utils/robot_model_test_utils.h> | ||
| #include <moveit/planning_request_adapter/planning_request_adapter.h> | ||
|
|
||
| class AppendingPlanningRequestAdapter final : public planning_request_adapter::PlanningRequestAdapter |
There was a problem hiding this comment.
Would you mind adding brief documentation for the classes and the test in this file?
There was a problem hiding this comment.
I don't have time to do this. Maybe, @Hugal31 can do so?
On the other hand, these classes are rather trivial and the names already state their semantics quite well.
m-elwin
pushed a commit
to m-elwin/moveit2
that referenced
this pull request
Dec 4, 2023
* Port unit test cherry-pick of moveit/moveit#3464 * Increment added_path_index in callAdapter Doesn't work because previous=0 for all recursively called functions. * Pass individual add_path_index vectors to callAdapter --------- Co-authored-by: Hugal31 <hla@lescompanions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moveit/moveit#3464 fixed an issue in the numbering of added path indices.
This PR ports this fix to MoveIt2. As the
added_path_indexvector was moved into theMotionPlanResponsestruct in #2285, I had to choose a slightly different approach.The first commit ports the (failing) unit test.
The second commit fixes the bug (and the test).