Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove added path index from function signatures #2285

Merged
merged 6 commits into from
Aug 15, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Aug 2, 2023

Description

  • Add added_path_index to MotionPlanResponse
  • Cleanup PlanRequestAdapter function signatures
  • Cleanup PlanningPipeline function signatures

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sjahr sjahr marked this pull request as ready for review August 4, 2023 16:57
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4476fb6) 50.72% compared to head (12e0f4d) 50.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2285      +/-   ##
==========================================
- Coverage   50.72%   50.71%   -0.00%     
==========================================
  Files         386      386              
  Lines       31914    31914              
==========================================
- Hits        16184    16181       -3     
- Misses      15730    15733       +3     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr linked an issue Aug 14, 2023 that may be closed by this pull request
@henningkayser henningkayser merged commit a2f0183 into moveit:main Aug 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make adapter_added_state_index part of the MotionPlanResponse
2 participants