Adding planning_frame and ee_frame to panda_simulated_config.yaml #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When implementing moveit servo for my own robot. The servo node crashed because planning_frame and ee_frame were not defined. This was a bit of a pain to debug because the error did not show up in the terminal log when the servo node was started as a node component (this may also be fixed). Disclaimer: I have not had time to test if this works with the example provided. So either wait until I do, or test it on your machine before approving.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2591 +/- ##
==========================================
+ Coverage 50.47% 50.84% +0.37%
==========================================
Files 387 388 +1
Lines 32183 32358 +175
==========================================
+ Hits 16241 16448 +207
+ Misses 15942 15910 -32 ☔ View full report in Codecov by Sentry. |
sea-bass
requested changes
Dec 8, 2023
There was a problem hiding this comment.
I think in the latest version of MoveIt Servo, we removed these parameters. See #2515 from about a month before this issue was opened.
So, I think maybe you are using this configuration on an older commit of this repository?
Were you building MoveIt 2 from source, or using the latest binaries?
|
@sea-bass you are right. I was using the docker image moveit/moveit2:rolling-release, instead of moveit/moveit2:rolling-source. Sorry for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing moveit servo for my own robot. The servo node crashed because planning_frame and ee_frame were not defined. This was a bit of a pain to debug because the error did not show up in the terminal log when the servo node was started as a node component (this may also be fixed).
Disclaimer: I have not had time to test if this works with the example provided. So either wait until I do, or test it on your machine before approving.