Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new clang-tidy style rules (backport #2177) #2619

Open
wants to merge 1 commit into
base: iron
Choose a base branch
from
Open

Add new clang-tidy style rules (backport #2177) #2619

wants to merge 1 commit into from
+1,668 −622

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 19, 2023

This is an automatic backport of pull request #2177 done by Mergify.
Cherry-pick of 63e0c3a has failed:

On branch mergify/bp/iron/pr-2177
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 63e0c3a39.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .clang-tidy
	modified:   moveit_core/collision_detection/test/test_world.cpp
	modified:   moveit_core/collision_detection_fcl/src/collision_common.cpp
	modified:   moveit_core/constraint_samplers/test/pr2_arm_kinematics_plugin.cpp
	modified:   moveit_core/constraint_samplers/test/pr2_arm_kinematics_plugin.h
	modified:   moveit_core/distance_field/test/test_distance_field.cpp
	modified:   moveit_core/kinematic_constraints/src/kinematic_constraint.cpp
	modified:   moveit_core/kinematic_constraints/test/test_orientation_constraints.cpp
	modified:   moveit_core/planning_interface/src/planning_interface.cpp
	modified:   moveit_core/planning_scene/test/test_planning_scene.cpp
	modified:   moveit_core/robot_model/src/joint_model_group.cpp
	modified:   moveit_core/robot_model/src/robot_model.cpp
	modified:   moveit_core/robot_state/src/conversions.cpp
	modified:   moveit_core/robot_state/test/test_cartesian_interpolator.cpp
	modified:   moveit_core/robot_state/test/test_kinematic_complex.cpp
	modified:   moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
	modified:   moveit_core/trajectory_processing/test/test_time_optimal_trajectory_generation.cpp
	modified:   moveit_core/utils/include/moveit/utils/moveit_error_code.h
	modified:   moveit_core/utils/include/moveit/utils/robot_model_test_utils.h
	modified:   moveit_core/utils/src/robot_model_test_utils.cpp
	modified:   moveit_planners/ompl/ompl_interface/scripts/generate_state_database.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/include/joint_limits_copy/joint_limits_rosparam.hpp
	modified:   moveit_planners/pilz_industrial_motion_planner/include/pilz_industrial_motion_planner/joint_limits_interface_extension.h
	modified:   moveit_planners/pilz_industrial_motion_planner/src/command_list_manager.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/joint_limits_aggregator.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/joint_limits_container.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/limits_container.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/move_group_sequence_action.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/move_group_sequence_service.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/pilz_industrial_motion_planner.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/planning_context_loader_circ.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/planning_context_loader_lin.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/planning_context_loader_ptp.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/trajectory_blender_transition_window.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/trajectory_functions.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/trajectory_generator.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/trajectory_generator_circ.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/trajectory_generator_lin.cpp
	modified:   moveit_planners/pilz_industrial_motion_planner/src/trajectory_generator_ptp.cpp
	modified:   moveit_planners/stomp/include/stomp_moveit/conversion_functions.hpp
	modified:   moveit_planners/stomp/include/stomp_moveit/cost_functions.hpp
	modified:   moveit_planners/stomp/include/stomp_moveit/filter_functions.hpp
	modified:   moveit_planners/stomp/include/stomp_moveit/noise_generators.hpp
	modified:   moveit_planners/stomp/include/stomp_moveit/trajectory_visualization.hpp
	modified:   moveit_planners/stomp/src/stomp_moveit_planning_context.cpp
	modified:   moveit_plugins/moveit_simple_controller_manager/src/follow_joint_trajectory_controller_handle.cpp
	modified:   moveit_py/src/moveit/core.cpp
	modified:   moveit_py/src/moveit/moveit_core/collision_detection/collision_common.cpp
	modified:   moveit_py/src/moveit/moveit_core/collision_detection/collision_common.h
	modified:   moveit_py/src/moveit/moveit_core/collision_detection/collision_matrix.cpp
	modified:   moveit_py/src/moveit/moveit_core/collision_detection/collision_matrix.h
	modified:   moveit_py/src/moveit/moveit_core/collision_detection/world.cpp
	modified:   moveit_py/src/moveit/moveit_core/collision_detection/world.h
	modified:   moveit_py/src/moveit/moveit_core/controller_manager/controller_manager.cpp
	modified:   moveit_py/src/moveit/moveit_core/controller_manager/controller_manager.h
	modified:   moveit_py/src/moveit/moveit_core/kinematic_constraints/utils.cpp
	modified:   moveit_py/src/moveit/moveit_core/kinematic_constraints/utils.h
	modified:   moveit_py/src/moveit/moveit_core/planning_interface/planning_response.cpp
	modified:   moveit_py/src/moveit/moveit_core/planning_interface/planning_response.h
	modified:   moveit_py/src/moveit/moveit_core/planning_scene/planning_scene.cpp
	modified:   moveit_py/src/moveit/moveit_core/planning_scene/planning_scene.h
	modified:   moveit_py/src/moveit/moveit_core/robot_model/joint_model.cpp
	modified:   moveit_py/src/moveit/moveit_core/robot_model/joint_model.h
	modified:   moveit_py/src/moveit/moveit_core/robot_model/joint_model_group.cpp
	modified:   moveit_py/src/moveit/moveit_core/robot_model/joint_model_group.h
	modified:   moveit_py/src/moveit/moveit_core/robot_model/robot_model.cpp
	modified:   moveit_py/src/moveit/moveit_core/robot_model/robot_model.h
	modified:   moveit_py/src/moveit/moveit_core/robot_state/robot_state.cpp
	modified:   moveit_py/src/moveit/moveit_core/robot_state/robot_state.h
	modified:   moveit_py/src/moveit/moveit_core/robot_trajectory/robot_trajectory.cpp
	modified:   moveit_py/src/moveit/moveit_core/robot_trajectory/robot_trajectory.h
	modified:   moveit_py/src/moveit/moveit_core/transforms/transforms.cpp
	modified:   moveit_py/src/moveit/moveit_core/transforms/transforms.h
	modified:   moveit_py/src/moveit/moveit_py_utils/include/moveit_py/moveit_py_utils/copy_ros_msg.h
	modified:   moveit_py/src/moveit/moveit_py_utils/src/copy_ros_msg.cpp
	modified:   moveit_py/src/moveit/moveit_ros/moveit_cpp/moveit_cpp.cpp
	modified:   moveit_py/src/moveit/moveit_ros/moveit_cpp/moveit_cpp.h
	modified:   moveit_py/src/moveit/moveit_ros/moveit_cpp/planning_component.cpp
	modified:   moveit_py/src/moveit/moveit_ros/moveit_cpp/planning_component.h
	modified:   moveit_py/src/moveit/moveit_ros/planning_scene_monitor/planning_scene_monitor.cpp
	modified:   moveit_py/src/moveit/moveit_ros/planning_scene_monitor/planning_scene_monitor.h
	modified:   moveit_py/src/moveit/planning.cpp
	modified:   moveit_ros/benchmarks/src/BenchmarkExecutor.cpp
	modified:   moveit_ros/hybrid_planning/global_planner/global_planner_component/src/global_planner_component.cpp
	modified:   moveit_ros/hybrid_planning/hybrid_planning_manager/hybrid_planning_manager_component/src/hybrid_planning_manager.cpp
	modified:   moveit_ros/move_group/src/move_group_capability.cpp
	modified:   moveit_ros/occupancy_map_monitor/src/occupancy_map_monitor.cpp
	modified:   moveit_ros/occupancy_map_monitor/src/occupancy_map_monitor_middleware_handle.cpp
	modified:   moveit_ros/perception/depth_image_octomap_updater/include/moveit/depth_image_octomap_updater/depth_image_octomap_updater.h
	modified:   moveit_ros/perception/depth_image_octomap_updater/src/depth_image_octomap_updater.cpp
	modified:   moveit_ros/perception/pointcloud_octomap_updater/include/moveit/pointcloud_octomap_updater/pointcloud_octomap_updater.h
	modified:   moveit_ros/perception/pointcloud_octomap_updater/src/pointcloud_octomap_updater.cpp
	modified:   moveit_ros/planning/plan_execution/src/plan_execution.cpp
	modified:   moveit_ros/planning/planning_pipeline_interfaces/include/moveit/planning_pipeline_interfaces/solution_selection_functions.hpp
	modified:   moveit_ros/planning/planning_pipeline_interfaces/src/solution_selection_functions.cpp
	modified:   moveit_ros/planning/planning_scene_monitor/include/moveit/planning_scene_monitor/planning_scene_monitor.h
	modified:   moveit_ros/planning/planning_scene_monitor/src/current_state_monitor.cpp
	modified:   moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp
	modified:   moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_objects.cpp
	modified:   moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_param_widget.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   moveit_core/planning_request_adapter/src/planning_request_adapter.cpp
	both modified:   moveit_core/robot_state/test/robot_state_jacobian_benchmark.cpp
	both modified:   moveit_core/robot_state/test/robot_state_test.cpp
	both modified:   moveit_core/robot_trajectory/include/moveit/robot_trajectory/robot_trajectory.h
	both modified:   moveit_core/robot_trajectory/src/robot_trajectory.cpp
	both modified:   moveit_core/robot_trajectory/test/test_robot_trajectory.cpp
	deleted by us:   moveit_core/utils/include/moveit/utils/logger.hpp
	deleted by us:   moveit_core/utils/src/logger.cpp
	deleted by us:   moveit_core/utils/test/logger_dut.cpp
	deleted by us:   moveit_core/utils/test/logger_from_child_dut.cpp
	both modified:   moveit_ros/perception/mesh_filter/include/moveit/mesh_filter/gl_renderer.h
	both modified:   moveit_ros/perception/mesh_filter/src/gl_renderer.cpp
	both modified:   moveit_ros/warehouse/src/broadcast.cpp
	both modified:   moveit_ros/warehouse/src/constraints_storage.cpp
	both modified:   moveit_ros/warehouse/src/import_from_text.cpp
	both modified:   moveit_ros/warehouse/src/initialize_demo_db.cpp
	both modified:   moveit_ros/warehouse/src/planning_scene_storage.cpp
	both modified:   moveit_ros/warehouse/src/planning_scene_world_storage.cpp
	both modified:   moveit_ros/warehouse/src/save_as_text.cpp
	both modified:   moveit_ros/warehouse/src/save_to_warehouse.cpp
	both modified:   moveit_ros/warehouse/src/state_storage.cpp
	both modified:   moveit_ros/warehouse/src/trajectory_constraints_storage.cpp
	both modified:   moveit_ros/warehouse/src/warehouse_connector.cpp
	both modified:   moveit_ros/warehouse/src/warehouse_services.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@sjahr @mergify
Add new clang-tidy style rules (#2177)
d0d1a13 
(cherry picked from commit 63e0c3a)

# Conflicts:
#	moveit_core/planning_request_adapter/src/planning_request_adapter.cpp
#	moveit_core/robot_state/test/robot_state_jacobian_benchmark.cpp
#	moveit_core/robot_state/test/robot_state_test.cpp
#	moveit_core/robot_trajectory/include/moveit/robot_trajectory/robot_trajectory.h
#	moveit_core/robot_trajectory/src/robot_trajectory.cpp
#	moveit_core/robot_trajectory/test/test_robot_trajectory.cpp
#	moveit_core/utils/include/moveit/utils/logger.hpp
#	moveit_core/utils/src/logger.cpp
#	moveit_core/utils/test/logger_dut.cpp
#	moveit_core/utils/test/logger_from_child_dut.cpp
#	moveit_ros/perception/mesh_filter/include/moveit/mesh_filter/gl_renderer.h
#	moveit_ros/perception/mesh_filter/src/gl_renderer.cpp
#	moveit_ros/warehouse/src/broadcast.cpp
#	moveit_ros/warehouse/src/constraints_storage.cpp
#	moveit_ros/warehouse/src/import_from_text.cpp
#	moveit_ros/warehouse/src/initialize_demo_db.cpp
#	moveit_ros/warehouse/src/planning_scene_storage.cpp
#	moveit_ros/warehouse/src/planning_scene_world_storage.cpp
#	moveit_ros/warehouse/src/save_as_text.cpp
#	moveit_ros/warehouse/src/save_to_warehouse.cpp
#	moveit_ros/warehouse/src/state_storage.cpp
#	moveit_ros/warehouse/src/trajectory_constraints_storage.cpp
#	moveit_ros/warehouse/src/warehouse_connector.cpp
#	moveit_ros/warehouse/src/warehouse_services.cpp
@mergify mergify bot added the conflicts label Dec 19, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conflicts stale Inactive issues and PRs are marked as stale and may be closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sjahr