Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message text about invalid servo parameters (backport #2769) #2771

Open
wants to merge 1 commit into
base: iron
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 26, 2024

Description

Was debugging something and realized this error message is swapped.

I'll add this later when I'm on a dev computer, but looks like we should also add a check for if ((servo_params.command_out_type == "std_msgs/Float64MultiArray") && !servo_params.publish_joint_positions && !servo_params.publish_joint_velocities) - The previous check would not trigger that as it is specific to Float64 type.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #2769 done by [Mergify](https://mergify.com).

(cherry picked from commit df78880)

# Conflicts:
#	moveit_ros/moveit_servo/src/servo.cpp
Copy link
Author

mergify bot commented Mar 26, 2024

Cherry-pick of df78880 has failed:

On branch mergify/bp/iron/pr-2769
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit df78880a0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_ros/moveit_servo/src/servo.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Mar 26, 2024
Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts stale Inactive issues and PRs are marked as stale and may be closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant