Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hybrid planning tutorial #97

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Jul 12, 2021

Description

A new tutorial for MoveIt 2's hybrid planning feature. WIP and blocked till the feature got merged into the MoveIt2's main branch (moveit2 #488)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@vatanaksoytezer
Copy link
Contributor

@sjahr do you mind tagging me when this is ready for review?

@sjahr sjahr force-pushed the add_hybrid_planning_tutorial branch from e1f132e to 6738608 Compare July 15, 2021 15:44
@sjahr sjahr changed the title WIP: Add hybrid planning tutorial Add hybrid planning tutorial Jul 15, 2021
@sjahr
Copy link
Contributor Author

sjahr commented Jul 15, 2021

@vatanaksoytezer This PR is ready to review. Thanks! The code links won't work because the hybrid planning feature is not merged yet. Not sure if we should wait for it with merging this PR after the review.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing such a nicely detailed tutorial. I left a few comments.

conf.py Outdated Show resolved Hide resolved
doc/hybrid_planning/CMakeLists.txt Outdated Show resolved Hide resolved
doc/hybrid_planning/config/local_planner.yaml Outdated Show resolved Hide resolved
doc/hybrid_planning/config/demo_controller.yaml Outdated Show resolved Hide resolved
@tylerjw tylerjw mentioned this pull request Oct 14, 2021
3 tasks
@mergify
Copy link

mergify bot commented Nov 8, 2021

This pull request is in conflict. Could you fix it @sjahr?

@AndyZe AndyZe force-pushed the add_hybrid_planning_tutorial branch from ad7926a to 57cbdd0 Compare November 17, 2021 18:39
@mergify
Copy link

mergify bot commented Nov 19, 2021

This pull request is in conflict. Could you fix it @sjahr?

@AndyZe AndyZe force-pushed the add_hybrid_planning_tutorial branch from 1d19790 to 3eb06eb Compare November 23, 2021 21:22
@AndyZe AndyZe force-pushed the add_hybrid_planning_tutorial branch from bfbbf15 to 99b71a9 Compare December 9, 2021 20:17
@vatanaksoytezer
Copy link
Contributor

@AndyZe can you add ros2 branch of moveit_msgs to repos file so that CI is happy and we can merge this.

@AndyZe AndyZe force-pushed the add_hybrid_planning_tutorial branch from 5dcc707 to 7fcbe4c Compare December 10, 2021 17:24
@mergify
Copy link

mergify bot commented Dec 14, 2021

This pull request is in conflict. Could you fix it @sjahr?

@AndyZe AndyZe merged commit f367e09 into moveit:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants