Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup with OpenCV 3.4.5 Debian package #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RoboticsYY
Copy link
Contributor

OpenCV 3.2, which is the default version on Ubuntu 18.04, is not working well for the ARUCO marker detection used in the hand-eye calibration. This PR provides a walk-around by installing OpenCV 3.4 through Debian packages.


git clone https://github.com/RoboticsYY/opencv_deb_install.git

find ./opencv_deb_install -name "OpenCV-3.4.5-x86_64-*.deb" | xargs sudo dpkg -i
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clearly not a reasonable long-term solution. What's the plan there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is not a perfect long-term solution, but to facilitate others to copy and test this tool. I have tested OpenCV 3.x and 4.1. Only 3.2 is not working well with Aruco marker detection. Actually we always avoid this version in any of our vision projects. Usually, I compile OpenCV from source. But this most likely will make CI timeout. I'm not sure if it's possible for Ubuntu to make a new version of OpenCV release with 18.04 or how far it would impact. One option in my head is to create PPA for this.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the PPA, if no compatible one already exists, would be a good simplification for users and should be preferred for CI over your custom binary git repo. Can you set this up and adapt this request?

The core issue is that the intuitive and default way to build this package (download and compile) apparently silently breaks tag detection and thus this package because it will use the standard system version.
So it's not enough to add a custom opencv version to the CI build, but the build should actually fail if you try to build with the broken version. You could add some error message referencing good versions of opencv and the ppa.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create a PPA for the non-default version of OpenCV for this.

Great idea to add some error message or compilation limitation! I think I will add some check and message print in cmake files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants