don't forward ROS_DISTRO to docker container #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ros-base docker container defines the correct ROS_DISTRO variable. Hence, there is no need to pass it from Travis to docker. Doing so, actually might conflict with specifying a DOCKER_IMAGE directly, because the ROS_DISTRO variables might have different values in docker and Travis.
|
It would be nice to document this in the README when you get a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to pass ROS_DISTRO from Travis to docker.
The ros-base docker container already defines the correct ROS_DISTRO variable.
In travis.sh the ROS_DISTRO was only required to resolve the name of the docker image.
However, when specifying the DOCKER_IMAGE directly, the passed ROS_DISTRO
variable might differ, and thus will override the variable defined by the actual ROS image.