Skip to content
This repository has been archived by the owner on Nov 13, 2017. It is now read-only.

catkin_lint and cleanup #305

Merged
merged 12 commits into from
Jul 7, 2016
Merged

catkin_lint and cleanup #305

merged 12 commits into from
Jul 7, 2016

Commits on Jul 3, 2016

  1. sort packages, components, and file lists

    @v4hn
    v4hn committed Jul 3, 2016
    Configuration menu
    Copy the full SHA
    0d9774a View commit details
    Browse the repository at this point in the history

  2. add missing declarations of std_msgs dependency

    @v4hn
    v4hn committed Jul 3, 2016
    Configuration menu
    Copy the full SHA
    2273686 View commit details
    Browse the repository at this point in the history

  3. sort entries in package.xml 

    This makes it possible to find something in there :)
    @v4hn
    v4hn committed Jul 3, 2016
    Configuration menu
    Copy the full SHA
    207e733 View commit details
    Browse the repository at this point in the history

  4. cleanup declared / used catkin dependencies

    @v4hn
    v4hn committed Jul 3, 2016
    Configuration menu
    Copy the full SHA
    e552462 View commit details
    Browse the repository at this point in the history

  5. cleanup test build in constraint_samplers 

    lint complained that REQUIRED was missing and orocos_kdl wasn't even include_dir'ed
    @v4hn
    v4hn committed Jul 3, 2016
    Configuration menu
    Copy the full SHA
    12e2ef2 View commit details
    Browse the repository at this point in the history

  6. don't dereference variable in cmake-if 

    catkin_lint pointed that out.
    @v4hn
    v4hn committed Jul 3, 2016
    Configuration menu
    Copy the full SHA
    4d613d3 View commit details
    Browse the repository at this point in the history

  7. don't use link_directories 

    This is discouraged use and users who put their libraries some place else,
have to register them in the system more low-level than within cmake
(e.g. LD_LIBRARY_PATH).
    @v4hn
    v4hn committed Jul 3, 2016
    Configuration menu
    Copy the full SHA
    9d909ad View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2016

  1. correctly reference octomap as a header dependency

    @v4hn
    v4hn committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    51d30fb View commit details
    Browse the repository at this point in the history

  2. install headers&libs using CATKIN_*_DESTINATION

    @v4hn
    v4hn committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    75b6b2d View commit details
    Browse the repository at this point in the history

  3. use PROJECT_NAME instead of the project's name 

    catkin_lint complains about this and it's a somewhat valid complain...
    @v4hn
    v4hn committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    ee5cb4f View commit details
    Browse the repository at this point in the history

  4. add notice that project will be built in Release mode 

    catkin_lint (rightfully) complains about this block that might
change CMAKE_BUILD_TYPE. Even so, without this block most people using
the git checkout (building locally) would wonder why MoveIt! is so slow
as they didn't specify Release build. So this will stay in here.
Nevertheless I suppose it's a good idea to leave a notice on the changed
build type in the logs.
    @v4hn
    v4hn committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    a2da363 View commit details
    Browse the repository at this point in the history

  5. move find_package for Eigen in line.. 

    ... with other ROS-external packages.
    @v4hn
    v4hn committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    d27cc2d View commit details
    Browse the repository at this point in the history