This repository has been archived by the owner on Nov 13, 2017. It is now read-only.
catkin_lint for kinetic #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to find something in there :)
lint complained that REQUIRED was missing and orocos_kdl wasn't even include_dir'ed
catkin_lint pointed that out.
This is discouraged use and users who put their libraries some place else, have to register them in the system more low-level than within cmake (e.g. LD_LIBRARY_PATH).
catkin_lint complains about this and it's a somewhat valid complain...
catkin_lint (rightfully) complains about this block that might change CMAKE_BUILD_TYPE. Even so, without this block most people using the git checkout (building locally) would wonder why MoveIt! is so slow as they didn't specify Release build. So this will stay in here. Nevertheless I suppose it's a good idea to leave a notice on the changed build type in the logs.
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically #305 for kinetic.