Skip to content
This repository has been archived by the owner on Nov 13, 2017. It is now read-only.

use GetIkType() instead of #defines #13

Merged
merged 2 commits into from
Sep 22, 2013
Merged

use GetIkType() instead of #defines #13

merged 2 commits into from
Sep 22, 2013

Conversation

mintar
Copy link
Contributor

@mintar mintar commented Sep 22, 2013

This removes the need to manually specify the IK type using #define IKTYPE_... and closes #5.

@mintar
Revert "Added IKTYPE_TRANSFORM_6D definition to solve issue moveit#5"
0c4b61a 
This reverts commit 041a914. As
explained in the issue moveit#5 comments, the #define should be inserted into
the generated code (either by the generator script or manually), *not*
set to one arbitrary value for all users. That would silently break the
generated code for all others.
@mintar
use GetIkType() instead of #defines
2dbdf54 
This removes the need to manually specify the IK type using `#define
IKTYPE_...` and closes moveit#5.
@davetcoleman
Copy link
Member

This is such an improvement, great work!

davetcoleman added a commit that referenced this pull request Sep 22, 2013
@davetcoleman
Merge pull request #13 from mintar/use_getiktype
810e777 
use GetIkType() instead of #defines
@davetcoleman davetcoleman merged commit 810e777 into moveit:master Sep 22, 2013
@cheffe112
Copy link
Contributor

Great job, @mintar, thanks a lot!

@cheffe112 cheffe112 mentioned this pull request Jul 15, 2014
Closed
@mintar mintar deleted the use_getiktype branch September 5, 2014 08:15
@nalt nalt mentioned this pull request Sep 8, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mintar @davetcoleman @cheffe112