Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub actions [master] #100

Merged
merged 2 commits into from Mar 19, 2021

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Mar 19, 2021

Similar to the ros2 version of this PR, this time for the master branch.

@tylerjw tylerjw force-pushed the add-github-actions-melodic branch 2 times, most recently from 24bf1d4 to b7de2fb Compare March 19, 2021 07:10
@tylerjw tylerjw changed the title Migrate to GitHub actions melodic Migrate to GitHub actions [master] Mar 19, 2021
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, otherwise looks good.

.github/workflows/industrial_ci_action.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also requires the CI badge change in README.md.

@tylerjw
Copy link
Member Author

tylerjw commented Mar 19, 2021

This also requires the CI badge change in README.md.

Good catch! Thank you, rebased the readme change in the migration commit.

@rhaschke rhaschke merged commit 515e0eb into moveit:master Mar 19, 2021
@tylerjw tylerjw deleted the add-github-actions-melodic branch March 19, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants