Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields to store planning time in pick-and-place #43

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Add fields to store planning time in pick-and-place #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions action/Pickup.action
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ string[] trajectory_descriptions
# The performed grasp, if attempt was successful
Grasp grasp

# The amount of time in seconds it took to complete the plan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ambiguous. Is it the time to plan or the time to execute the plan? Maybe reword to "it took to generate a plan"

float64 planning_time
---

# The internal state that the pickup action currently is in
Expand Down
2 changes: 2 additions & 0 deletions action/Place.action
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ string[] trajectory_descriptions
# The successful place location, if any
PlaceLocation place_location

# The amount of time in seconds it took to complete the plan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ambiguous. Is it the time to plan or the time to execute the plan? Maybe reword to "it took to generate a plan"

float64 planning_time
---

# The internal state that the place action currently is in
Expand Down