#19 introduced a conflicting set of launch files

[rhaschke]

With #19 being merged, we now have the following error:

$ roslaunch moveit_resources demo.launch 
RLException: multiple files named [demo.launch] in package [moveit_resources]:
- /vol/famula/nightly/ros/melodic/share/moveit_resources/fanuc_moveit_config/launch/demo.launch
- /vol/famula/nightly/ros/melodic/share/moveit_resources/panda_moveit_config/launch/demo.launch
Please specify full path instead

I think, as long as the tests explicitly specify which launch file(s) to use, there is no problem.
Nevertheless, should we take any action, e.g. remove fanuc, or add prefixes to all launch files?

[v4hn]

This sounds very much like we should fix it, I agree. It might not confuse beginners who copy the tutorial, but slightly more experienced users who use roslaunch "properly".. One way (would break the setup assistant though) would be to prefix all the launch files. How about renaming the folders to `moveit_fanuc_moveit_config`, etc., and make them proper packages (again)?

[rhaschke]

Making them separate packages will probably break a lot of tests (which rely on moveit_resources being the package that provides all those launch files).
The other issue I was seeing with this approach (namely introducing potentially conflicting package names), you avoid by renaming the packages as well.
I agree with @v4hn that renaming those packages will be the cleanest solution.

[davetcoleman]

Seems like the simplest fix for now is to prefix the roslaunch files as @v4hn suggested. Rename them to fanuc_demo.launch and panda_demo.launch

[rhaschke]

Seems like the simplest fix for now is to prefix the roslaunch files as @v4hn suggested. Rename them to fanuc_demo.launch and panda_demo.launch

Actually, we would need to rename all the launch files. @v4hn proposed to add new packages and rename their folders.

[rhaschke]

Fixed for quite some while.