changelogs and version bump for foxy release #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
reviewed
Jul 7, 2020
Comment on lines
+7
to
+12
| * Update joint_state_publisher dependency (`#31 <https://github.com/ros-planning/moveit_resources/issues/31>`_) | ||
| * Port to ROS 2 Eloquent (`#26 <https://github.com/ros-planning/moveit_resources/issues/26>`_) | ||
| * Run Travis CI on ROS 2 Eloquent | ||
| * Create moveit_resources.repos | ||
| * Port CMakeLists.txt & package.xml to ROS2 | ||
| * Travis: use ROS2 branch of moveit_ci (`#25 <https://github.com/ros-planning/moveit_resources/issues/25>`_) |
There was a problem hiding this comment.
#31 was just a fixup of #26. No need to explicitly list that in the changelogs.
Suggested change
| * Update joint_state_publisher dependency (`#31 <https://github.com/ros-planning/moveit_resources/issues/31>`_) | |
| * Port to ROS 2 Eloquent (`#26 <https://github.com/ros-planning/moveit_resources/issues/26>`_) | |
| * Run Travis CI on ROS 2 Eloquent | |
| * Create moveit_resources.repos | |
| * Port CMakeLists.txt & package.xml to ROS2 | |
| * Travis: use ROS2 branch of moveit_ci (`#25 <https://github.com/ros-planning/moveit_resources/issues/25>`_) | |
| * Port and modernize CMakeLists.txt + package.xml to ROS2 (`#26 <https://github.com/ros-planning/moveit_resources/issues/26>`_, `#31 <https://github.com/ros-planning/moveit_resources/issues/31>`_) | |
| * Travis: Port to ROS2 (`#25 <https://github.com/ros-planning/moveit_resources/issues/25>`_) |
|
@henningkayser what are your thoughts on waiting (and syncing) the upcoming changes in moveit_resources. |
I think it makes sense to wait for #36 and sync the changes, ideally we should try to be on the same level as the Noetic release. What are your thoughts on bumping the version to 2.0 similar to other ROS2 packages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.