adding trigger call to animations if (batch_publishing_enabled_) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davetcoleman
requested changes
Sep 6, 2018
src/moveit_visual_tools.cpp
Outdated
| @@ -438,7 +438,8 @@ bool MoveItVisualTools::publishAnimatedGrasps(const std::vector<moveit_msgs::Gra | |||
| break; | |||
|
|
|||
| publishAnimatedGrasp(possible_grasps[i], ee_jmg, animate_speed); | |||
|
|
|||
| if (batch_publishing_enabled_) | |||
| trigger(); | |||
| ros::Duration(0.1).sleep(); | |||
There was a problem hiding this comment.
side note: this sleep should be customizable - e.g. pause_between_grasps
There was a problem hiding this comment.
Can we reuse animate_sleep?
src/moveit_visual_tools.cpp
Outdated
| @@ -438,7 +438,8 @@ bool MoveItVisualTools::publishAnimatedGrasps(const std::vector<moveit_msgs::Gra | |||
| break; | |||
|
|
|||
| publishAnimatedGrasp(possible_grasps[i], ee_jmg, animate_speed); | |||
|
|
|||
| if (batch_publishing_enabled_) | |||
| trigger(); | |||
There was a problem hiding this comment.
interesting. it seems to me this trigger actually belongs inside publishAnimatedGrasp() because it has its own for-loop that publishes the motion of the end effector. thoughts?
There was a problem hiding this comment.
Good point. Will change accordingly
|
@mlautman Did you notice the " // Display Grasp Score" feature inside animate grasps? |
|
@davetcoleman ready for merge? |
|
i don't see any pushed updates to the code |
mlautman
force-pushed
the
trigger-animations
branch
from
43a4da0
to
12b6423
Compare
|
My bad. I hadn't pushed |
davetcoleman
approved these changes
Sep 14, 2018
|
cherry picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.