use specified color_ for EndEffector marker #96
Conversation
Addresses this clang warning
<<<
moveit_visual_tools/include/moveit_visual_tools/imarker_end_effector.h:150:29: error: private field 'color_' is not used [-Werror,-Wunused-private-field]
rviz_visual_tools::colors color_ = rviz_visual_tools::PURPLE;
^
1 error generated.
>>>
We could have removed the member just as well (it barely matters...),
but that would entail an unnecessary API change in the constructor.
I added the default value for the constructor parameter as it is always overwritten until now...
| marker.color.r = 0.5; | ||
| marker.color.g = 0.5; | ||
| marker.color.b = 0.5; |
There was a problem hiding this comment.
This isn't purple but grey...
There was a problem hiding this comment.
Yes, but I don't see an issue with this (tiny) change in behavior. If you disagree please change it before merging 🐈
Yes and no. I believe the best way to go forward upon finding an issue is by fixing it. 😄 Feel free to patch the MoveIt CI further to be less strict on downstream dependencies if you like. |
|
The specific color could be change in a follow on PR. I am going to merge these PRs so we can get CI working again for moveit. |
Related to moveit/moveit#2792 .
Addresses this clang warning
<<<
moveit_visual_tools/include/moveit_visual_tools/imarker_end_effector.h:150:29: error: private field 'color_' is not used [-Werror,-Wunused-private-field]
rviz_visual_tools::colors color_ = rviz_visual_tools::PURPLE;
^
1 error generated.
We could have removed the member just as well (it barely matters...),
but that would entail an unnecessary API change in the constructor.
I added the default value for the constructor parameter as it is always overwritten until now...